Small adjustments for the i18n install script#178
Open
Narrat wants to merge 2 commits intobootchk:resynthesizer3from
Open
Small adjustments for the i18n install script#178Narrat wants to merge 2 commits intobootchk:resynthesizer3from
Narrat wants to merge 2 commits intobootchk:resynthesizer3from
Conversation
Else it will scale poorly if there are new plug-ins and languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions for the new install script :)
First commit introduces a check if
msgfmtis availabe. If not it should cleanly abort the operation.And the second one puts the installation process into nested for-loops. Which should avoid copy and paste operations (which can be error-prone) in the future.
Currently one behavioural change with this though.
eswill now be installed too. I assume this was excluded because it was only partially translated?